jewel: osd: OSD failed to subscribe skipped osdmaps after ceph osd pause #10804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
std::map::insert() does not overwrite existing items with the same key. so we need to do this in a different way. and we will check sub_sent aftewards, so we need to keep an updated sub_sent around. Fixes: http://tracker.ceph.com/issues/17023 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 5508149)
if any OSD is full or the pause flag is set in cluster, objecter will always try to subscribe the next osdmap using the mon client shared with OSD. but if the OSD's osdmap is very far behind on osd maps due to some reasons, `MonClient::sub_want_increment()` will reject the subscribe request from OSD, because it's asking for older maps while the mon client is about to send the request from objecter for the *next* osdmap. so we need to update objecter with the latest local osdmap, so it is able to skip the new osdmaps if OSD needs to catch up with the cluster first. Fixes: http://tracker.ceph.com/issues/17023 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 1515e08)
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 22, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 23, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2016
…maps after ceph osd pause Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@tchaikov does this backport look good to merge ? It passed the rados suite http://tracker.ceph.com/issues/16344#note-39 (except for one known bug that is, I believe, unrelated and one environmental failure on an erasure code job). |
|
lgtm. |
ghost
merged commit 
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17089