Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: do not link against unused objects or libraries #10837

Merged
merged 2 commits into from Aug 26, 2016
Merged

Conversation

tchaikov
Copy link
Contributor

No description provided.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
@wjwithagen
Copy link
Contributor

@tchaikov
I'll run this thru my FreeBSD config.
But I will first have to fix a conflict between std-includeds and the log system.
I think this due my OS upcrade to the current FreeBSD HEAD :-(

In file included from /usr/include/c++/v1/cmath:301:
/usr/include/c++/v1/math.h:845:37: error: reference to 'log' is ambiguous
log(_A1 __lcpp_x) _NOEXCEPT {return log((double)__lcpp_x);}
                                    ^
/usr/include/c++/v1/math.h:845:1: note: candidate found by name lookup is 'log'
log(_A1 __lcpp_x) _NOEXCEPT {return log((double)__lcpp_x);}
^
/usr/include/c++/v1/math.h:839:46: note: candidate found by name lookup is 'log'
inline _LIBCPP_INLINE_VISIBILITY long double log(long double __lcpp_x) _NOEXCEPT {return logl(__lcpp_x);}
                                             ^
/usr/include/c++/v1/math.h:838:46: note: candidate found by name lookup is 'log'
inline _LIBCPP_INLINE_VISIBILITY float       log(float __lcpp_x) _NOEXCEPT       {return logf(__lcpp_x);}
                                             ^
/usr/include/math.h:247:8: note: candidate found by name lookup is 'log'
double  log(double);
        ^
/home/wjw/ceph/src/common/ceph_context.h:44:13: note: candidate found by name lookup is 'ceph::log'
  namespace log {
            ^

@wjwithagen
Copy link
Contributor

@tchaikov
LGTM

Currently I only compile librbd on FreeBSD, but there I already had the stuff you are fixing removed.
So that is a certainly oke on FreeBSD.
With the other fixes there is a big change I can start compiling and test more of the RBD stuff.

@tchaikov tchaikov merged commit 90836aa into master Aug 26, 2016
@tchaikov tchaikov deleted the wip-cmake branch August 26, 2016 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants