os/bluestore: fix when block device is not a multiple of the block size #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
We might have a backing device that is an odd number of 512-byte sectors but have the block_size configured to 4096. Ensure the reported size rounds down to avoid confusing other layers of the stack. Signed-off-by: Sage Weil <sage@redhat.com>
ghost
self-assigned this
|
jenkins test this please |
2016-08-24 20:44:53.774324 7f50eff8a040 1 bluefs add_block_extent bdev 1 0x100000~7efce00 /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueFS.cc: In function 'void BlueFS::add_block_extent(unsigned int, uint64_t, uint64_t)' thread 7f50eff8a040 time 2016-08-24 20:44:53.774333 /home/jenkins-build/build/workspace/ceph-pull-requests/src/os/bluestore/BlueFS.cc: 138: FAILED assert(bdev[id]->get_size() >= offset + length) jenkins test this please because we want to make sure it is because of this pull request |
These should be a multiple of the block size (since we are feeding the size directly into add_block_extent). Signed-off-by: Sage Weil <sage@redhat.com>
|
Fixed! |
ghost
merged commit
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fsck after mkfs by default.