jewel: fs: fix double-unlock on shutdown #10847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
There's an extra lock in there too below your change. |
We did a bad backport or something and accidentally ended up with two Unlock() calls on mds_lock. Don't. Signed-off-by: Greg Farnum <gfarnum@redhat.com>
ghost
assigned 
gregsfortytwo
force-pushed
the
jewel-fix-mds
branch
from
21e24ab
to
577336e
Compare
|
Crap, fixed and thanks. |
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
|
ghost
pushed a commit
that referenced
this pull request
Aug 24, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2016
Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
http://tracker.ceph.com/issues/16344#note-38 passes except for one unrelated java failure. |
ghost
merged commit 
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17126
We did a bad backport or something and accidentally ended up with two Unlock()
calls on mds_lock. Don't.
Signed-off-by: Greg Farnum gfarnum@redhat.com