rgw: remove duplicated calls to getattr #10858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1290,7 +1290,7 @@ int rgw_getattr(struct rgw_fs *rgw_fs, | |||
| rc = -(fs->getattr(rgw_fh, st)); | |||
| } | |||
|
|
|||
| return -(fs->getattr(rgw_fh, st)); | |||
There was a problem hiding this comment.
I can't remember what I was playing with here, but I think we want just this line (return -(expr)), and to zap the two calls that assign rc. What do you think?
There was a problem hiding this comment.
I think it would be OK. I will change the pull-request.
|
@atheism you're right, this was some kind of experiement, the calls are idempotent, at least in the current code. I think maybe we should take the more concise form though. |
|
@atheism I'd tweak the commit msg--the reason to fs->getattr() (once :) is that it's the implementation of the API method. |
Signed-off-by: Weibing Zhang <zhangweibing@unitedstack.com>
atheism
force-pushed
the
rgw_getattr-return
branch
from
80a9ddf
to
87b550e
Compare
atheism
changed the title
|
jenkins, retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need the duplicated calls to getattr. Remove the unnecessary code.
Signed-off-by: Weibing Zhang zhangweibing@unitedstack.com