Enable builds without ceph-test subpackage #10872

rjfd · 2016-08-25T15:04:32Z

Fixes: http://tracker.ceph.com/issues/16776

Signed-off-by: Ricardo Dias rdias@suse.com

smithfarm · 2016-08-25T15:36:35Z

👍 This is very useful for speeding up the build (and making it less resource-hungry) for times when you don't need the ceph-tests package.

rjfd · 2016-08-26T10:21:29Z

Rebased to resolve conflicts with yesterday commits.

smithfarm · 2016-08-26T10:29:36Z

ceph.spec.in

@@ -1391,6 +1401,8 @@ ln -sf %{_libdir}/librbd.so.1 /usr/lib64/qemu/librbd.so.1
 %{python3_sitelib}/__pycache__/ceph_daemon.cpython*.py*
 %endif

+#################################################################################


@rjfd Please drop this divider line (all other divider lines were dropped by #9757)

rjfd · 2016-08-26T16:59:01Z

@smithfarm done with dropping

smithfarm · 2016-08-28T12:22:37Z

pushed wip-16776 to gitbuilders

smithfarm · 2016-08-28T16:39:52Z

gitbuilders passed!

smithfarm · 2016-08-28T16:42:48Z

Validation test (CentOS 7.2):

pass http://pulpito.front.sepia.ceph.com:80/smithfarm-2016-08-28_16:42:29-upgrade:jewel-x-wip-16776---basic-smithi/

Validation test (Ubuntu 14.04):

pass http://pulpito.front.sepia.ceph.com:80/smithfarm-2016-08-28_16:44:02-upgrade:jewel-x-wip-16776---basic-smithi/

smithfarm · 2016-08-28T19:18:32Z

@b-ranto @ktdreyer @tchaikov Care to review?

smithfarm · 2016-08-28T19:19:39Z

Jenkins test this please

tchaikov · 2016-08-29T01:31:14Z

lgtm

ktdreyer · 2016-08-29T15:18:02Z

Would you please also move ceph-client-debug in debian/ceph-base.install to debian/ceph-test.install ?

rjfd · 2016-08-30T07:30:06Z

@ktdreyer done

ktdreyer · 2016-08-30T13:44:45Z

LGTM

smithfarm · 2016-09-02T07:57:46Z

@tchaikov What additional testing does this PR need?

tchaikov · 2016-09-02T13:54:55Z

@smithfarm better off running it through a rados run, just to make sure the nothing is missing in the ceph-test package.

smithfarm · 2016-09-05T20:49:17Z

ok, repushed wip-16776 to pick up the latest commit

smithfarm · 2016-09-09T11:20:56Z

@rjfd Please rebase - there is a conflict.

Signed-off-by: Ricardo Dias <rdias@suse.com>

rjfd · 2016-09-09T11:56:35Z

@smithfarm rebase done

tchaikov · 2016-09-09T11:58:35Z

@rjfd and @smithfarm will pull this PR into my test branch for the qa run.

smithfarm · 2016-09-09T12:12:02Z

@tchaikov Thanks!

tchaikov · 2016-09-09T12:19:13Z

src/tools/CMakeLists.txt

@@ -46,9 +48,15 @@ if(WITH_LIBCEPHFS)
  install(TARGETS ceph-client-debug DESTINATION bin)
 endif(WITH_LIBCEPHFS)

+if(WITH_TESTS)


@rjfd you might want to move this block into https://github.com/ceph/ceph/pull/10872/files#diff-65c9cee53e3f940aed5b8ad9942ff108L44 .

see http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-deb-trusty-amd64-basic/log.cgi?log=33dbbbf9b7cf43326ebf29e322422df698116ff6

…naries Signed-off-by: Ricardo Dias <rdias@suse.com>

…test package Fixes: http://tracker.ceph.com/issues/16776 Signed-off-by: Ricardo Dias <rdias@suse.com>

Signed-off-by: Ricardo Dias <rdias@suse.com>

rjfd · 2016-09-09T13:14:15Z

@tchaikov thanks for catching that! I fixed it and pushed the new changes.

smithfarm · 2016-09-09T15:28:04Z

(issue#16776) Enable RPM build without ceph-test subpackage

tchaikov · 2016-09-11T03:20:36Z

tested at http://pulpito.ceph.com/kchai-2016-09-10_15:46:37-rados-wip-kefu-testing---basic-mira/408471/

the failed test of http://pulpito.ceph.com/kchai-2016-09-10_15:46:37-rados-wip-kefu-testing---basic-mira/408471/ is irrelevant.

smithfarm added feature build/ops labels Aug 25, 2016

tchaikov mentioned this pull request Aug 25, 2016

cmake: add WITH_TESTS option to disable test subdir #10287

Closed

rjfd force-pushed the wip-16776 branch from 453321b to 15718e5 Compare August 26, 2016 10:20

smithfarm reviewed Aug 26, 2016
View reviewed changes

rjfd force-pushed the wip-16776 branch from 15718e5 to 7bae427 Compare August 26, 2016 16:58

smithfarm self-assigned this Aug 26, 2016

tchaikov added the needs-qa label Aug 29, 2016

ktdreyer changed the title ~~rpm: Enable RPM build without ceph-test subpackage~~ Enable builds without ceph-test subpackage Aug 30, 2016

rjfd added 2 commits September 9, 2016 12:55

rpm: Moved ceph-client-debug from ceph-base to ceph-test package

aaa75ae

Signed-off-by: Ricardo Dias <rdias@suse.com>

rpm: Renamed bcond tests flag to make_check

06875b5

Signed-off-by: Ricardo Dias <rdias@suse.com>

rjfd force-pushed the wip-16776 branch from 9e2f6e8 to b941443 Compare September 9, 2016 11:56

tchaikov added the wip-kefu-testing label Sep 9, 2016

tchaikov self-assigned this Sep 9, 2016

smithfarm removed their assignment Sep 9, 2016

tchaikov reviewed Sep 9, 2016
View reviewed changes

rjfd added 3 commits September 9, 2016 14:12

cmake: Use WITH_TESTS flag to guard the build of ceph-test scripts/bi…

a8f8598

…naries Signed-off-by: Ricardo Dias <rdias@suse.com>

rpm: Added ceph_test_package bcond flag to control the build of ceph-…

0f347b8

…test package Fixes: http://tracker.ceph.com/issues/16776 Signed-off-by: Ricardo Dias <rdias@suse.com>

deb: Moved ceph-client-debug from ceph-base to ceph-test package

d3ac8d1

Signed-off-by: Ricardo Dias <rdias@suse.com>

rjfd force-pushed the wip-16776 branch from b941443 to d3ac8d1 Compare September 9, 2016 13:12

tchaikov merged commit 64d8a79 into ceph:master Sep 11, 2016

smithfarm mentioned this pull request May 22, 2017

dmclock: initial commit of dmclock QoS library #14330

Merged

gregsfortytwo mentioned this pull request Feb 26, 2015

backport ceph-fuse file locking patches to Firefly #3730

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable builds without ceph-test subpackage #10872

Enable builds without ceph-test subpackage #10872

rjfd commented Aug 25, 2016

smithfarm commented Aug 25, 2016 •

edited

rjfd commented Aug 26, 2016

smithfarm Aug 26, 2016 •

edited

rjfd commented Aug 26, 2016

smithfarm commented Aug 28, 2016

smithfarm commented Aug 28, 2016

smithfarm commented Aug 28, 2016 •

edited

smithfarm commented Aug 28, 2016

smithfarm commented Aug 28, 2016

tchaikov commented Aug 29, 2016

ktdreyer commented Aug 29, 2016

rjfd commented Aug 30, 2016

ktdreyer commented Aug 30, 2016

smithfarm commented Sep 2, 2016

tchaikov commented Sep 2, 2016 •

edited

smithfarm commented Sep 5, 2016

smithfarm commented Sep 9, 2016

rjfd commented Sep 9, 2016

tchaikov commented Sep 9, 2016

smithfarm commented Sep 9, 2016

tchaikov Sep 9, 2016

tchaikov Sep 9, 2016

rjfd commented Sep 9, 2016

smithfarm commented Sep 9, 2016

tchaikov commented Sep 11, 2016

Enable builds without ceph-test subpackage #10872

Enable builds without ceph-test subpackage #10872

Conversation

rjfd commented Aug 25, 2016

smithfarm commented Aug 25, 2016 • edited

rjfd commented Aug 26, 2016

smithfarm Aug 26, 2016 • edited

Choose a reason for hiding this comment

rjfd commented Aug 26, 2016

smithfarm commented Aug 28, 2016

smithfarm commented Aug 28, 2016

smithfarm commented Aug 28, 2016 • edited

smithfarm commented Aug 28, 2016

smithfarm commented Aug 28, 2016

tchaikov commented Aug 29, 2016

ktdreyer commented Aug 29, 2016

rjfd commented Aug 30, 2016

ktdreyer commented Aug 30, 2016

smithfarm commented Sep 2, 2016

tchaikov commented Sep 2, 2016 • edited

smithfarm commented Sep 5, 2016

smithfarm commented Sep 9, 2016

rjfd commented Sep 9, 2016

tchaikov commented Sep 9, 2016

smithfarm commented Sep 9, 2016

tchaikov Sep 9, 2016

Choose a reason for hiding this comment

tchaikov Sep 9, 2016

Choose a reason for hiding this comment

rjfd commented Sep 9, 2016

smithfarm commented Sep 9, 2016

tchaikov commented Sep 11, 2016

smithfarm commented Aug 25, 2016 •

edited

smithfarm Aug 26, 2016 •

edited

smithfarm commented Aug 28, 2016 •

edited

tchaikov commented Sep 2, 2016 •

edited