mds: remove max_mds config option #10914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Reviewed-by |
| @@ -530,7 +530,7 @@ OPTION(mds_inject_traceless_reply_probability, OPT_DOUBLE, 0) /* percentage | |||
| OPTION(mds_wipe_sessions, OPT_BOOL, 0) | |||
| OPTION(mds_wipe_ino_prealloc, OPT_BOOL, 0) | |||
| OPTION(mds_skip_ino, OPT_INT, 0) | |||
| OPTION(max_mds, OPT_INT, 1) | |||
| OPTION(max_mds, OPT_INT, 1) // Obsolete and ignored! Use `ceph fs set max_mds` instead. | |||
There was a problem hiding this comment.
Why not just kill it entirely? I don't think unknown config options will break anything, and leaving it in is confusing.
It is now required that all changes to max_mds use the run-time `ceph fs set max_mds` command. The rationale for this change is that it is confusing to have a configuration for max_mds which is only observed at file system creation. Fixes: http://tracker.ceph.com/issues/17105 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
This makes the necessary `ceph fs` calls to get it running. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
force-pushed
the
mds-no-maxmds
branch
from
3664554
to
29535ca
Compare
|
@gregsfortytwo thanks, I made that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now required that all changes to max_mds use the run-time
ceph fs set max_mdscommand. The rationale for this change is that it is confusing to have a configuration for max_mds which is only observed at file system creation.Fixes: http://tracker.ceph.com/issues/17105