rgw: fix regression with handling double underscore #10939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/16856 Signed-off-by: Orit Wasserman <owasserm@redhat.com>
|
tested this on master and the patch seems to work as intended, also solves all the other issues we ran int. haven't tested on jewel yet. |
| @@ -308,7 +308,8 @@ static int read_policy(RGWRados *store, | |||
| obj.init_ns(bucket, oid, mp_ns); | |||
| obj.set_in_extra_data(true); | |||
| } else { | |||
| obj = rgw_obj(bucket, object); | |||
| obj = rgw_obj(bucket, object.name); | |||
| obj.set_instance(s->object.instance); | |||
There was a problem hiding this comment.
@oritwas while this might fix the issue, I'm having trouble understanding what's going on and why it should or shouldn't work. Sounds like there's a deeper problem that we should be fixing.
There was a problem hiding this comment.
@oritwas reading the code further, I now understand the issue. We should get this fix in, and then rework rgw_obj and rgw_obj_key for future versions.
|
@yehudasa ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/16856
Signed-off-by: Orit Wasserman owasserm@redhat.com