cmake: pass -DINTEL* to gf-complete cflags #10956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Reviewed-by: Loic Dachary <ldachary@redhat.com> |
* in addition to the -march=foobar, we also need to pass -DFOOBAR to gf-complete sources' cflags, so that the SIMD instructions can be generated as expected. * also extract the compiler support for instruction extensions detections into SIMDExt.cmake. * and only check the compiler support if CMAKE_SYSTEM_PROCESSOR matches with the instruction-set/arch to be checked. Signed-off-by: tone.zhang <tone.zhang@linaro.org> Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@dachary thanks for your review. i just realized that we should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gf-complete sources' cflags, so that the SIMD instructions can be
generated as expected.
into SIMDExt.cmake.
with the instruction-set/arch to be checked.
Signed-off-by: tone.zhang tone.zhang@linaro.org
Signed-off-by: Kefu Chai kchai@redhat.com