Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: honour allow-eio flag; use global compressor if possible #10970

Merged
merged 2 commits into from Sep 6, 2016
Merged

os/bluestore: honour allow-eio flag; use global compressor if possible #10970

merged 2 commits into from Sep 6, 2016

Conversation

xiexingguo
Copy link
Member

No description provided.

@xiexingguo
os/bluestore: honour allow-eio flag during read
fa2dce8 
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
Copy link
Member Author

Passed local test:

2016-09-03 18:26:43.900272 7f87ebe73640  1 bluestore(store_test_temp_dir) fsck finish with 0 errors
[       OK ] ObjectStore/StoreTest.TooManyBlobsTest/2 (22093 ms)
[----------] 60 tests from ObjectStore/StoreTest (1849735 ms total)

[----------] Global test environment tear-down
[==========] 60 tests from 1 test case ran. (1849736 ms total)
[  PASSED  ] 60 tests.

@xiexingguo xiexingguo force-pushed the xxg-wip-honour-alloweio-flag branch 2 times, most recently from ae38951 to 1fddea4 Compare September 3, 2016 14:45
@xiexingguo
Copy link
Member Author

retest this please

ifed01
ifed01 reviewed Sep 5, 2016
View reviewed changes
src/os/bluestore/BlueStore.cc
CompressorRef compressor = Compressor::create(cct, name);
if (!compressor.get()) {
CompressorRef cp;
if (compressor != nullptr && compressor->get_type() == name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please do an assignment cp = compressor; first to avoid potential race condition with _set_compression method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ifed01 Fixed, Igor. Thanks!

@xiexingguo
os/bluestore: use global compressor if possible
f6bea31 
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
Copy link
Member Author

retest this please

@liewegas liewegas merged commit e6a39ae into ceph:master Sep 6, 2016
@xiexingguo xiexingguo deleted the xxg-wip-honour-alloweio-flag branch September 6, 2016 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@liewegas liewegas

Labels
bluestore
Projects
None yet
Milestone
No milestone
3 participants
@xiexingguo @ifed01 @liewegas