CmakeLists.txt: use LIB_RESOLV instead of resolv. #10972
Conversation
- FreeBSD does not have a separate libresolv, but keeps it in libc Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
|
@tchaikov |
|
jenkins, retest this please |
And I'm having this also in other jenkins runs that are totally not related. |
| find_package(Python3Interp 3 REQUIRED) | ||
| find_package(Python3Libs 3 REQUIRED) | ||
| find_package(Python3Interp 3 QUIET) | ||
| find_package(Python3Libs 3 QUIET) |
There was a problem hiding this comment.
could you drop this commit? it breaks the build if python3 is missing, see src/pybind/CMakeLists.txt.
There was a problem hiding this comment.
@tchaikov
I think it is the other way around.
With QUIET the absence of python3 stuff is sillently ignored.
If I test with REQUIRED, things seriously blow up in my face on some Jenkins runs where there is python3 to be installed. And things really stop during CMake processing.
So I added this to actually get some testing. (Now it stops on the last test due to timeout, and unrelated to this commit.)
But perhaps somebody fixed the python stuff in the mean time.
I'll drop this extra commit.
wjwithagen
force-pushed
the
wip-wjw-cmake-resolv
branch
from
09510bf
to
e3f2567
Compare
libc
Signed-off-by: Willem Jan Withagen wjw@digiware.nl