os/bluestore/BlueFS: For logs of rocksdb & bluefs only use directio. #11012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it use bluefs_buffered_io to control whether use buffer or directio when write. But in fact for logs of rocksdb & bluefs, whether bluefs_buffer_io is true or false, the logs only need directio. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
|
This appears to be causing a ~10% performance regression with 4K random writes on NVMe devices when bluefs_buffer_io is set to true. |
|
Upon further testing, it looks like the majority, if not all, of the effect is coming from the second part of the conditional, ie "h->writer_type == WRITER_WAL". I don't know why this would be the case however. |
|
Huh. For now, let's just switch the conditional to just ino == 1.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it use bluefs_buffered_io to control whether use buffer or directio
when write. But in fact for logs of rocksdb & bluefs, whether
bluefs_buffer_io is true or false, the logs only need directio.
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com