cmake: make py3 a nice-to-have #11015
Conversation
|
@tchaikov I'll give your commit a run for its money this afternoon. |
| elseif(WITH_PY3) | ||
| find_package(Python3Interp 3 REQUIRED) | ||
| find_package(Python3Libs 3 REQUIRED) | ||
| endif() |
There was a problem hiding this comment.
@tchaikov
Why not move all this into src/pybind/CMakeLists.txt
that way everything is close together.
Visually it looks like this will work.
There was a problem hiding this comment.
i didn't check if other included CMakeLists.txt scripts are using the variables exposed by find_package(Python3Interp 3) and find_package(Python3Libs) or not. so not sure about this.
|
@tchaikov So now I can go back and start figuring out why my OSDs are not noup-ing only to the booting state. |
python3 is not a hard requirement to build ceph, so make it optional. add an option named "WITH_PYTHON3" which accepts ON, OFF, or CHECK. Fixes: http://tracker.ceph.com/issues/17103 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-optional-py3
branch
from
3d980e5
to
7d7a984
Compare
|
@wjwithagen thanks for testing! @jdurgin what do you think? changelog
|
|
Looks good for the cmake part of http://tracker.ceph.com/issues/17103. Thanks! |
python3 is not a hard requirement to build ceph, so make it optional.
add an option named "WITH_PY3" which accepts ON, OFF, or CHECK.
Signed-off-by: Kefu Chai kchai@redhat.com