mds: Set mds_snap_max_uid to 4294967294 #11016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcsp ping! :) We might want to move this setting to a 'ceph fs set snap_min_uid X' / 'ceph fs set snap_min_max Y' setting as well in the future? |
Since kernel version 2.6 the Linux kernel supports 32-bit integers and thus the limit is no longer 65536. By setting this to a higher default value we make sure that all users will be allowed to create snapshots in the future by default. Signed-off-by: Wido den Hollander <wido@42on.com>
|
Change looks reasonable, added to list for testing. I agree that moving this setting into FSMap would make sense, because it's a per-filesystem thing more than a per-daemon thing. |
|
@jcsp Yes, I think moving it seems logical to me as well. When this config setting was introduced a long time ago this was the only way. Let's up the max UID limit here and then move it to the FSMap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since kernel version 2.6 the Linux kernel supports 32-bit integers
and thus the limit is no longer 65536.
By setting this to a higher default value we make sure that all users
will be allowed to create snapshots in the future by default.
Signed-off-by: Wido den Hollander wido@42on.com