jewel: rgw: back off bucket sync on failures, don't store marker #11021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/16742 If we fail on any single entry in bucket, skip updating the marker tracker so that next time we'll go over that entry, and back off. This will trigger a report to the data sync error repo and eventually a retry on the failing object. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 1f3fec8)
and returns true if needed to be called again Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit 5528932)
Was not tracking high markers correctly. Could only work if there was a single hole in the completion range. Just keep a map of all the complete entries. Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit f5801c7)
Signed-off-by: Yehuda Sadeh <yehuda@redhat.com> (cherry picked from commit aacc31f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/16794