os/bluestore: fix offset bug in _do_write_small. #11030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The statement "if (ep->logical_offset + b->get_blob().get_ondisk_length() <= offset)" which try to judge if the writing offset is in the current Blob may be wrong. Signed-off-by: feng yu amoxic@126.com
| @@ -6964,7 +6964,7 @@ void BlueStore::_do_write_small( | |||
| if (ep != o->extent_map.extent_map.begin()) { | |||
| --ep; | |||
| b = ep->blob; | |||
| if (ep->logical_offset + b->get_blob().get_ondisk_length() <= offset) { | |||
| if ((ep->logical_offset - ep->blob_offset) + b->get_blob().get_ondisk_length() <= offset) { | |||
There was a problem hiding this comment.
No need for parentheses.
Have you run ceph_test_objectstore for your patch?
There was a problem hiding this comment.
I ran ceph_test_objectstore(only BlueStore), here is the result.
[----------] Global test environment tear-down
[==========] 61 tests from 1 test case ran. (9295011 ms total)
[ PASSED ] 61 tests.
liewegas
changed the title
Signed-off-by: feng yu amoxic@126.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The statement "if (ep->logical_offset + b->get_blob().get_ondisk_length() <= offset)" which try to judge if the writing offset is in the current Blob may be wrong.
Signed-off-by: feng yu amoxic@126.com