Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix potential access violation during rename #11033

Merged
merged 6 commits into from Sep 12, 2016

Conversation

xiexingguo
Copy link
Member

No description provided.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The get_key_extent_shard() method shall decompose extent_shard_key
into onode_key and offset, but currently we don't fill onode_key
and return it to caller.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
The empty() method also needs to be called under the protection of lock.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Otherwise is_spanning() has no caller and shall be deleted.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
Copy link
Member Author

Tested locally:

2016-09-10 12:05:48.476003 7f1112be4640  1 bluestore(store_test_temp_dir) fsck finish with 0 errors in 0.507159 seconds
[       OK ] ObjectStore/StoreTest.TooManyBlobsTest/2 (24504 ms)
[----------] 61 tests from ObjectStore/StoreTest (2755808 ms total)

[----------] Global test environment tear-down
[==========] 61 tests from 1 test case ran. (2755808 ms total)
[  PASSED  ] 61 tests.

@liewegas liewegas merged commit 7ba551a into ceph:master Sep 12, 2016
@xiexingguo xiexingguo deleted the xxg-wip-bluestore-0909 branch September 12, 2016 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants