librbd: extract group module from librbd/internal #11070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VictorDenisov
force-pushed
the
consistency_groups_extract_module
branch
from
75e6836
to
21b56f2
Compare
dillaman
reviewed
Sep 15, 2016
| @@ -560,6 +560,7 @@ $DAEMONOPTS | |||
| filestore wbthrottle btrfs ios start flusher = 10 | |||
| filestore wbthrottle btrfs ios hard limit = 20 | |||
| filestore wbthrottle btrfs inodes hard limit = 30 | |||
| journal dio = false | |||
There was a problem hiding this comment.
Minor: appears to be an unrelated change
| @@ -17,6 +17,7 @@ set(librbd_internal_srcs | |||
| ImageCtx.cc | |||
| ImageState.cc | |||
| ImageWatcher.cc | |||
| Group.cc | |||
There was a problem hiding this comment.
Minor: move between ExclusiveLock and ImageCtx to keep alphabetical
| @@ -0,0 +1,382 @@ | |||
|
|
|||
|
|
||
| #define dout_subsys ceph_subsys_rbd | ||
| #undef dout_prefix | ||
| #define dout_prefix *_dout << "librbd: " |
| namespace librbd { | ||
| // Consistency groups functions | ||
|
|
||
| int group_create(librados::IoCtx& io_ctx, const char *group_name) |
There was a problem hiding this comment.
Minor: no indentation required within a namespace
| std::vector<group_image_status_t>& images); | ||
| int image_get_group(ImageCtx *ictx, group_spec_t *group_spec); | ||
| } | ||
| #endif |
There was a problem hiding this comment.
Minor: "#endif // CEPH_LIBRBD_GROUP_H"
dillaman
changed the title
VictorDenisov
force-pushed
the
consistency_groups_extract_module
branch
from
21b56f2
to
7cc97fc
Compare
dillaman
reviewed
Sep 15, 2016
|
|
||
| return 0; | ||
| } | ||
| } |
| #define CEPH_LIBRBD_GROUP_H | ||
|
|
||
| namespace librbd { | ||
| // Consistency groups functions |
There was a problem hiding this comment.
Minor: no indentation required for namespace -- just leave a blank line between the namespace block and its contents for clarity.
Signed-off-by: Victor Denisov <denisovenator@gmail.com>
VictorDenisov
force-pushed
the
consistency_groups_extract_module
branch
from
7cc97fc
to
36d2d8a
Compare
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.