run-cmake-check.sh: Remove redundant calls #11116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling "git submodule init" is redundant since it is called in do_cmake.sh and there's no reason to do a modprobe of rbd.ko here either. Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
|
Looks like @dachary put it in the original run-make-check.sh (b9ddf97) and @dmick removed it from that file with "modprobe won't work on containers; not needed" (bf5ccce). Looks like run-cmake-check.sh was copied from run-make-check.sh somewhere in between. This also raises the question of whether we need both run-make-check.sh and run-cmake-check.sh? I suspect the answer is "no". |
|
I put it there because some tests run via make check relied on the rbd module being loaded. Since it does not seem to be the case anymore, I don't see why it should be kept around. Reviewed-by: Loic Dachary <ldachary@redhat.com> |
|
FWIW I don't recall any such tests, and we shouldn't be doing a manual modprobe anyway. LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling "git submodule init" is redundant since it is called in do_cmake.sh and
there's no reason to do a modprobe of rbd.ko here either.
Signed-off-by: Brad Hubbard bhubbard@redhat.com