mds: catch duplicates in DamageTable #11137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an implicit assumption in the code that callers wouldn't hit the notify_*damaged paths twice because they would have checked is_*_damaged paths first. However, that's not really true in all cases, e.g. scrub code isn't required to respect existing damage entries when trying to load a CDir. Simply fix this by having the DamageTable notify* functions check the key they're inserting doesn't already exist. Fixes: http://tracker.ceph.com/issues/17173 Signed-off-by: John Spray <john.spray@redhat.com>
|
@fullerdj quick review please? |
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an implicit assumption in the code that callers
wouldn't hit the notify__damaged paths twice because they would
have checked is___damaged paths first.
However, that's not really true in all cases, e.g. scrub
code isn't required to respect existing damage entries
when trying to load a CDir.
Simply fix this by having the DamageTable notify* functions
check the key they're inserting doesn't already exist.
Fixes: http://tracker.ceph.com/issues/17173
Signed-off-by: John Spray john.spray@redhat.com