mds: handle blacklisting during journal recovery #11138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 19, 2016 20:31
The MDS is a client to the OSDs, and responds to blacklists by respawning itself. Usually respawns of a daemonized process result in a PID change, but it's not guaranteed, and it's definitely not the case when someone runs in foreground (e.g. teuthology). Using a random nonce makes sure we won't match against an existing blacklist entry from a failed instance of an MDS daemon with the same name as us. Related to: http://tracker.ceph.com/issues/17236 Signed-off-by: John Spray <john.spray@redhat.com>
EBLACKLISTED was being incorrectly handled as an indication of metadata damage. Fixes: http://tracker.ceph.com/issues/17236 Signed-off-by: John Spray <john.spray@redhat.com>
|
@gregsfortytwo could you review please? |
gregsfortytwo
approved these changes
Sep 23, 2016
There was a problem hiding this comment.
Seems to still need testing, but otherwise,
Reviewed-by: Greg Farnum gfarnum@redhat.com
|
Was tested on this branch: http://pulpito.ceph.com/jspray-2016-09-21_18:37:24-fs-wip-jcsp-greenish-distro-basic-smithi/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EBLACKLISTED was being incorrectly handled as an
indication of metadata damage.
Fixes: http://tracker.ceph.com/issues/17236