osd: fix rados write op hang #11143
Merged
osd: fix rados write op hang #11143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if primary OSD handle a write op and do_osd_ops return errro code, record_write_error will try to record it into pglog and send log message to replica. but if replica OSD crash right now, the primary OSD will call on_change to free all repop, and do_update_log_missing_reply will not be called, so the write op will lost and hangs. this patch fix it. Signed-off-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com>
|
@jdurgin ping |
|
nice catch! looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if primary OSD handle a write op and do_osd_ops return errro code,
record_write_error will try to record it into pglog and send log message
to replica.
but if replica OSD crash right now, the primary OSD will call
on_change to free all repop, and do_update_log_missing_reply will not
be called, so the write op will lost and hangs.
this patch fix it.
Signed-off-by: Yunchuan Wen yunchuan.wen@kylin-cloud.com