rbd-mirror: replicate image metadata settings #11168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs #10980 to be merged first to avoid merge conflicts. |
trociny
changed the title
dillaman
reviewed
Sep 21, 2016
| return r; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Minor: check for m_image_ctx.read_only?
dillaman
reviewed
Sep 21, 2016
| op_event->on_op_finish_event = new C_RefreshIfRequired<I>( | ||
| m_image_ctx, new ExecuteOp<I, journal::MetadataRemoveEvent>( | ||
| m_image_ctx, event, on_op_complete)); | ||
|
|
There was a problem hiding this comment.
Minor: add "op_event->ignore_error_codes = {-ENOENT}" to ignore replay errors
|
Minor: can you add new test cases to test_mock_Replay and test_Replay for the new events? |
|
@dillaman Thanks for the comments. Updated. |
|
@trociny Still would like to see a journal/test_mock_Replay test case |
added 2 commits
September 28, 2016 16:28
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
Fixes: http://tracker.ceph.com/issues/16212 Signed-off-by: Mykola Golub <mgolub@mirantis.com>
trociny
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/16212
Signed-off-by: Mykola Golub mgolub@mirantis.com