Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg: make loopback Connection feature accurate all the time #11183

Merged
merged 1 commit into from Oct 11, 2016
Merged

msg: make loopback Connection feature accurate all the time #11183

merged 1 commit into from Oct 11, 2016

Conversation

liewegas
Copy link
Member

In 626360a we made the
OSD cluster loopback connection CEPH_FEATURES_ALL, but
all other loopback connections got features == 0. I
can't come up with any reason we wouldn't want those
connections to have accurate feature bits, so let's just
use CEPH_FEATURES_ALL for all of them.

While we're here, make the cflags argument required.

Signed-off-by: Sage Weil sage@redhat.com

@liewegas
Copy link
Member Author

@dzafman

@xiexingguo
Copy link
Member

Does not compile?

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestOSDScrub.cc: In member function ‘virtual void TestOSDScrub_scrub_time_permit_Test::TestBody()’:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestOSDScrub.cc:61:22: error: no matching function for call to ‘Messenger::create(CephContext*&, const string&, entity_name_t, const char [13], __pid_t)’
              getpid());
                      ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestOSDScrub.cc:61:22: note: candidate is:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/Watch.h:20:0,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.h:42,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/PG.h:33,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/OSD.h:18,
                 from /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/TestOSDScrub.cc:24:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/msg/Messenger.h:164:21: note: static Messenger* Messenger::create(CephContext*, const string&, entity_name_t, std::string, uint64_t, uint64_t)
   static Messenger *create(CephContext *cct,

@liewegas liewegas modified the milestone: kraken Oct 4, 2016
@tchaikov
Copy link
Contributor

tchaikov commented Oct 9, 2016

needs rebase.

@tchaikov
Copy link
Contributor

tested at http://pulpito.ceph.com/kchai-2016-10-09_12:58:06-rados-wip-kefu-testing---basic-mira/ after applying de54c1d

failed tests are tracked at

@liewegas
msg: make loopback Connection feature accurate all the time
0dbe8fd 
In 626360a we made the
OSD cluster loopback connection CEPH_FEATURES_ALL, but
all other loopback connections got features == 0.  I
can't come up with any reason we wouldn't want those
connections to have accurate feature bits, so let's just
use CEPH_FEATURES_ALL for all of them.

While we're here, make the cflags argument required.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas
Copy link
Member Author

rebased

@tchaikov tchaikov removed the needs-qa label Oct 10, 2016
@tchaikov tchaikov self-assigned this Oct 10, 2016
@tchaikov tchaikov merged commit bee4218 into ceph:master Oct 11, 2016
@tchaikov
Copy link
Contributor

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tchaikov tchaikov

Labels
bug-fix core
Projects
None yet
Milestone
kraken
3 participants
@liewegas @xiexingguo @tchaikov