Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: quiesce in-flight event commits before shut down #11185

Merged
merged 2 commits into from Sep 28, 2016

Conversation

dillaman
Copy link

No description provided.

@trociny
Copy link
Contributor

trociny commented Sep 24, 2016

@dillaman Could you please rebase when you have time?

Jason Dillaman added 2 commits September 25, 2016 08:44
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/17355
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
@dillaman
Copy link
Author

@trociny rebased and pushed

@trociny
Copy link
Contributor

trociny commented Sep 27, 2016

lgtm

trociny pushed a commit that referenced this pull request Sep 28, 2016
rbd-mirror: quiesce in-flight event commits before shut down #11185
@trociny trociny merged commit ba6785f into ceph:master Sep 28, 2016
@dillaman dillaman deleted the wip-17355 branch September 28, 2016 20:17
@trociny
Copy link
Contributor

trociny commented Sep 29, 2016

@dillaman I missed that some tests (fsx) got stuck in the teuthology queue, and only today I received the result. One of the fsx tests, which uses journaling, fails when calling journaler.register_client():

http://qa-proxy.ceph.com/teuthology/trociny-2016-09-28_07:53:36-rbd-wip-mgolub-testing---basic-vps/442458/teuthology.log

2016-09-28T10:20:05.702 INFO:teuthology.orchestra.run.vpm031.stderr:/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-11.0.0-2752-g5a03650/src/common/AsyncOpTracker.cc: In function 'AsyncOpTracker::~AsyncOpTracker()' thread 7f03aa415380 time 2016-09-28 10:20:05.700397
2016-09-28T10:20:05.702 INFO:teuthology.orchestra.run.vpm031.stderr:/srv/autobuild-ceph/gitbuilder.git/build/out~/ceph-11.0.0-2752-g5a03650/src/common/AsyncOpTracker.cc: 14: FAILED assert(m_pending_ops == 0)
2016-09-28T10:20:05.702 INFO:teuthology.orchestra.run.vpm031.stderr: ceph version v11.0.0-2752-g5a03650 (5a036504a18c12f3d400c2c1dbe556ebfca6f75e)
2016-09-28T10:20:05.702 INFO:teuthology.orchestra.run.vpm031.stderr: 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x8b) [0x7f03aa0c405b]
2016-09-28T10:20:05.703 INFO:teuthology.orchestra.run.vpm031.stderr: 2: (()+0x143e82) [0x7f03aa0bfe82]
2016-09-28T10:20:05.703 INFO:teuthology.orchestra.run.vpm031.stderr: 3: (journal::JournalMetadata::~JournalMetadata()+0x56) [0x7f03aa096416]
2016-09-28T10:20:05.703 INFO:teuthology.orchestra.run.vpm031.stderr: 4: (journal::JournalMetadata::~JournalMetadata()+0x9) [0x7f03aa0965e9]
2016-09-28T10:20:05.703 INFO:teuthology.orchestra.run.vpm031.stderr: 5: (RefCountedObject::put()+0xe7) [0x7f03aa087207]
2016-09-28T10:20:05.703 INFO:teuthology.orchestra.run.vpm031.stderr: 6: (journal::Journaler::~Journaler()+0x24) [0x7f03aa088b44]
2016-09-28T10:20:05.703 INFO:teuthology.orchestra.run.vpm031.stderr: 7: (()+0xfbaf5) [0x7f03aa077af5]
2016-09-28T10:20:05.704 INFO:teuthology.orchestra.run.vpm031.stderr: 8: (create_image()+0x137) [0x7f03aa077d27]
2016-09-28T10:20:05.704 INFO:teuthology.orchestra.run.vpm031.stderr: 9: (main()+0x6fd) [0x7f03aa072a9d]
2016-09-28T10:20:05.704 INFO:teuthology.orchestra.run.vpm031.stderr: 10: (__libc_start_main()+0xf5) [0x7f039665af45]
2016-09-28T10:20:05.704 INFO:teuthology.orchestra.run.vpm031.stderr: 11: (()+0xf8c13) [0x7f03aa074c13]

It look it should wait for journal metadata async_notify_update to complete before completing the context. What do you think about this PR #11257?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants