tests: use a fixture for memstore clone testing #11190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re.cc so it can be reused by other tests like test_memstore_clone. Signed-off-by: Kefu Chai <kchai@redhat.com>
so it will issues a fatal error if anything goes wrong, instead of continuing with the test cases. Signed-off-by: Kefu Chai <kchai@redhat.com>
rename test case name from `MemStore` to `MemStoreClone`, because if we use `TEST_F` to group the tests into a fixture, `MemStore` will be used as the class name of the fixture, and hence conflicts with the existing `MemStore` class under testing. but the object store is created and destroyed for every test. before this change, we do this for every test case. if it's a concern we need to use SetUpTestCase() and TearDownTestCase() instead. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-memstore-clone-fixture
branch
from
811cc7e
to
0cad3dc
Compare
|
@tchaikov you, sir, are the coolest. this looks much better. tested and working for me, and jenkins is happy with it too thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.