osd/ReplicatedPG: remove unneeded use of count #11251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
requested changes
Sep 28, 2016
| @@ -5936,7 +5937,8 @@ int ReplicatedPG::do_osd_ops(OpContext *ctx, vector<OSDOp>& ops) | |||
| for (map<string, pair<bufferlist, int> >::iterator i = assertions.begin(); | |||
| i != assertions.end(); | |||
| ++i) { | |||
| bufferlist &bl = out.count(i->first) ? | |||
| auto out_entry = out.find(i->first); | |||
| bufferlist &bl = (out_entry != out.end()) ? | |||
There was a problem hiding this comment.
since we don't reuse out_entry, i think the use of count() here is correct?
There was a problem hiding this comment.
@liewegas
I forgotten to use it in the next line, I have pushed the corrected commit.
Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
stiopaa1
force-pushed
the
osd_replicatedpg_removeCount2
branch
from
ec76937
to
ff264ce
Compare
liewegas
approved these changes
Sep 29, 2016
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Jarzabek stiopa@gmail.com