librbd: fix rollback if failed to disable mirroring for image #11260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Sep 30, 2016
| r = mirror_image_disable_internal(ictx, force); | ||
| if (r < 0) { | ||
| return r; | ||
| r = mirror_image_disable_internal(ictx, force); |
There was a problem hiding this comment.
I believe this was outside the block due to snap_lock being held.
There was a problem hiding this comment.
sorry, did not notice the lock :(
updated and moved the code needs the snap_lock into a block.
thanks.
runsisi
force-pushed
the
wip-fix-mirror-image-disable
branch
from
f2981c2
to
5581510
Compare
Signed-off-by: runsisi <runsisi@zte.com.cn>
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 18, 2016
If given only 8GB RAM, ceph_test_msgr may abort with buffer::bad_alloc. http://tracker.ceph.com/issues/11260 Fixes: ceph#11260 Signed-off-by: Loic Dachary <loic@dachary.org> (cherry picked from commit eac791c)
liewegas
pushed a commit
that referenced
this pull request
Dec 14, 2016
If given only 8GB RAM, ceph_test_msgr may abort with buffer::bad_alloc. http://tracker.ceph.com/issues/11260 Fixes: #11260 Signed-off-by: Loic Dachary <loic@dachary.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable mirroring for demoted image stucks in disabling state
Signed-off-by: runsisi runsisi@zte.com.cn