rgw: fixes for virtual hosting of buckets #11280

cbodley · 2016-09-30T19:58:28Z

this brings back the fix from @robbat2 that was reverted in #10873, with an additional check that disables the virtual hosting feature if no hostnames were configured. this prevents default configurations (such as teuthology) from treating all requests as virtual hosted buckets

also updated the docs - a preview should eventually be available at http://docs.ceph.com/docs/wip-17440/radosgw/s3/commons/

robbat2

One comment about the other set variable for staticsites hostnames below.

Also, maybe I'm not seeing it, but we don't actually enforce that any of the entries from the zonegroup hostnames are non-empty; they just seem to be copied from the zonegroup to the set variables.

robbat2 · 2016-10-01T00:40:46Z

src/rgw/rgw_rest.cc

    if (subdomain.empty()
        && (domain.empty() || domain != info.host)
        && !looks_like_ip_address(info.host.c_str())
-        && RGWHandler_REST::validate_bucket_name(info.host)) {
+        && RGWHandler_REST::validate_bucket_name(info.host) == 0
+        && !hostnames_set.empty()) {


This should check hostnames_s3website_set as well. If either of them are non-empty, it should be ok (should be very rare, but want to check anyway).

The logic (added in 46aae19) for falling back to just using the hostname as the possible bucket name contained an accidental inversion, because RGWHandler_REST::validate_bucket_name returns success as zero. Backport: jewel Fixes: http://tracker.ceph.com/issues/17136 Re-Fixes: http://tracker.ceph.com/issues/15975 Signed-off-by: Robin H. Johnson <robin.johnson@dreamhost.com>

if no hostnames are configured, all requests were treated as virtual hosted buckets. require at least one hostname in hostnames_set to consider setting in_hosted_domain Fixes: http://tracker.ceph.com/issues/17440 Signed-off-by: Casey Bodley <cbodley@redhat.com>

Signed-off-by: Casey Bodley <cbodley@redhat.com>

std::accumulate() was appending hostnames without commas or spaces Signed-off-by: Casey Bodley <cbodley@redhat.com>

robbat2 · 2016-10-03T23:28:23Z

I ran into one related impact from this, that should be clarified & documented.
RGW's legacy behavior differs from S3 behavior, and s3-tests was designed around the RGW legacy behavior: using the path calling format, and assuming that the hostname it was connecting to was also configured as the rgw dns name or zonegroup hostname.

Thus, in some cases, we know get a lot more false-positive s3-tests breakage.

GET /foobar/ HTTP/1.1
Host: non-existing-ceph-buckettest.example.com

AWS-S3 treats this as bucket {{non-existing-ceph-buckettest.example.com}}, and returns:

<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>NoSuchBucket</Code>
<Message>The specified bucket does not exist</Message>
<BucketName>non-existing-ceph-buckettest.example.com</BucketName>
<RequestId>D1F9F7DCD9D79A11</RequestId>
<HostId>1RGXmTwGt4w2R+BV/xiuJsmJoIwVZsjhwEBH2Qrqh4URbV0zlIvX1+9KczHCCKHnhtV7Mhh7Ps8=</HostId>
</Error>

RGW, prior to my patching, treats this as bucket {{foobar}}, and returns:

<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>NoSuchBucket</Code>
<BucketName>foobar</BucketName>
<RequestId>tx0000000000000000025fb-0057f2e73e-fa74-default</RequestId>
<HostId>fa74-default-default</HostId>
</Error>

RGW, with patch, now matches AWS-S3:

<?xml version="1.0" encoding="UTF-8"?>
<Error>
<Code>NoSuchBucket</Code>
<BucketName>non-existing-ceph-buckettest.example.com</BucketName>
<RequestId>tx0000000000000000c6085-0057f2e721-10bb00c9-default</RequestId>
<HostId>10bb00c9-default-default</HostId>
</Error>

cbodley · 2016-10-13T18:08:44Z

oops, i was cleaning up branches and nuked this one. reopened

robbat2 · 2016-10-26T23:32:30Z

@cbodley @yehudasa what happened to having this merged in v10.2.4? I'm writing documentation for StaticSites, and it depends on having this merged.

oritwas · 2016-10-28T08:27:41Z

lgtm.
I scheduled a teuthology run: http://pulpito.ceph.com/owasserm-2016-10-27_16:41:06-rgw-wip-17440---basic-mira/
and on the vps : http://pulpito.ceph.com/owasserm-2016-10-28_08:30:00-rgw-wip-17440---basic-vps/

oritwas · 2016-10-31T09:55:48Z

jenkins test this please

oritwas · 2016-11-01T09:13:42Z

new run (previous runs had enviorment problems): http://pulpito.ceph.com/owasserm-2016-10-31_18:27:38-rgw-wip-orit-17440---basic-mira/

cbodley · 2016-11-01T14:00:17Z

thanks @oritwas !

cbodley added bug-fix documentation rgw labels Sep 30, 2016

cbodley assigned robbat2 and yehudasa Sep 30, 2016

cbodley force-pushed the wip-17440 branch 3 times, most recently from cd350bd to 632c603 Compare September 30, 2016 20:28

robbat2 reviewed Oct 1, 2016

View reviewed changes

Robin H. Johnson and others added 5 commits October 3, 2016 14:25

doc: configuring virtual hosted buckets for radosgw

36203c2

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: filter out empty virtual bucket hostnames

aa34b98

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: add commas to hostname output

2d6efe8

std::accumulate() was appending hostnames without commas or spaces Signed-off-by: Casey Bodley <cbodley@redhat.com>

cbodley force-pushed the wip-17440 branch from 94852f0 to 2d6efe8 Compare October 3, 2016 18:37

robbat2 approved these changes Oct 3, 2016

View reviewed changes

cbodley added the wip-cbodley-testing label Oct 4, 2016

cbodley closed this Oct 10, 2016

cbodley deleted the wip-17440 branch October 10, 2016 15:08

cbodley restored the wip-17440 branch October 13, 2016 18:08

cbodley reopened this Oct 13, 2016

cbodley removed the wip-cbodley-testing label Oct 24, 2016

oritwas merged commit 63e86e5 into master Nov 1, 2016

cbodley deleted the wip-17440 branch November 1, 2016 13:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rgw: fixes for virtual hosting of buckets #11280

rgw: fixes for virtual hosting of buckets #11280

cbodley commented Sep 30, 2016

robbat2 left a comment

robbat2 Oct 1, 2016

cbodley Oct 3, 2016

robbat2 commented Oct 3, 2016

cbodley commented Oct 13, 2016

robbat2 commented Oct 26, 2016

oritwas commented Oct 28, 2016 •

edited

oritwas commented Oct 31, 2016

oritwas commented Nov 1, 2016

cbodley commented Nov 1, 2016

rgw: fixes for virtual hosting of buckets #11280

rgw: fixes for virtual hosting of buckets #11280

Conversation

cbodley commented Sep 30, 2016

robbat2 left a comment

Choose a reason for hiding this comment

robbat2 Oct 1, 2016

Choose a reason for hiding this comment

cbodley Oct 3, 2016

Choose a reason for hiding this comment

robbat2 commented Oct 3, 2016

cbodley commented Oct 13, 2016

robbat2 commented Oct 26, 2016

oritwas commented Oct 28, 2016 • edited

oritwas commented Oct 31, 2016

oritwas commented Nov 1, 2016

cbodley commented Nov 1, 2016

oritwas commented Oct 28, 2016 •

edited