rbd-mirror HA: move librbd::image_watcher::Notifier to librbd::object_watcher #11290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Oct 3, 2016
|
|
||
| namespace librbd { | ||
|
|
||
| struct ImageCtx; | ||
|
|
||
| namespace image_watcher { | ||
|
|
||
| class Notifier { | ||
| class Notifier : public object_watcher::Notifier { |
There was a problem hiding this comment.
Minor: since this class doesn't appear to do anything anymore, can you just swap the current calls to image_watcher::Notifier to object_watcher::Notifier?
…_watcher Fixes: http://tracker.ceph.com/issues/17017 Signed-off-by: Mykola Golub <mgolub@mirantis.com>
|
@dillaman updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17017
Signed-off-by: Mykola Golub mgolub@mirantis.com