os/bluestore: make cache settings process-wide #11295
Merged
+161
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wondering if |
Divide by the shard count so that the user isn't totally confused. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Onodes, buffers, buffer bytes. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-cache
branch
from
4a5da2e
to
4802e96
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-cache
branch
from
4802e96
to
0118293
Compare
ifed01
reviewed
Oct 4, 2016
| /// ctor for lookup only | ||
| explicit Extent(uint32_t lo) : logical_offset(lo) { } | ||
| /// ctor for delayed intitialization (see decode_some()) | ||
| explicit Extent(Cache *cache) { |
There was a problem hiding this comment.
IMHO specific blob assignment method that also increments cache counter(s) is more transparent and error prone, e.g.
void Extent::assign_blob(BlobRef b) {
if(blob) blob->shared_blob->bc.cache->rm_extent();
blob = b;
if( blob ) blob->shared_blob->bc.cache->add_extent();
}
ifed01
reviewed
Oct 4, 2016
| } | ||
| ~Extent() { | ||
| if (blob) { | ||
| blob->shared_blob->bc.cache->rm_extent(); | ||
| } | ||
| } | ||
|
|
||
| void assign_blob(const BlobRef& b) { | ||
| blob = b; |
There was a problem hiding this comment.
assert(!blob) here to catch if someday we call assign_blob twice for some reason?
liewegas
force-pushed
the
wip-bluestore-cache
branch
from
c96a473
to
da7ab00
Compare
More explicit, less error-prone. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-bluestore-cache
branch
from
da7ab00
to
304a3b1
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and a bunch of other stuff, including instrumenting cache onodes, extents, blobs, buffers, bytes.