os/bluestore: pack a few more in-memory types #11328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
272 -> 264 bytes Signed-off-by: Sage Weil <sage@redhat.com>
224 -> 216 bytes Signed-off-by: Sage Weil <sage@redhat.com>
Saves 24 bytes! BufferSpace 104 -> 80 bytes SharedBlob 216 -> 192 bytes Signed-off-by: Sage Weil <sage@redhat.com>
160 -> 152 bytes Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
We were tracking buffers by seq. In reality, though, we won't have very many buffers that have in flight IO to the same blob at the same time, so we can get by with just a list here. We can rely on the fact that the list will be sorted (seq's increase, and we put new buffers at the end). This saves us a memory allocation. No change in size of BufferSpace and Blob (std::list -> intrusive::list). Signed-off-by: Sage Weil <sage@redhat.com>
|
To build this needs the writing_map changed to writing in Blob::can_split (BlueStore.h) and Bufferspace::split (BlueStore.cc). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.