os/bluestore: switch spanning_blob_map to std::map #11336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intrusive map overhead on Blob is expensive when a tiny fraction of Blobs actually end up in the spanning_blob_map. Let's pay the extra allocation overhead (for the map node holding the BlobRef) for those rare cases. Signed-off-by: Sage Weil <sage@redhat.com>
|
This is going to be much better I think! Should let us cache some more onodes at the very least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intrusive map overhead on Blob is expensive when a tiny fraction of
Blobs actually end up in the spanning_blob_map. Let's pay the extra
allocation overhead (for the map node holding the BlobRef) for those rare
cases.
Signed-off-by: Sage Weil sage@redhat.com