compressor: fixes and tests; disable zlib isal (it's broken) #11349
Conversation
|
@Ved-vampir the zlib ISA-L code seems to be broken. I've disabled it in this PR. Can you take a look? Just revert the commit and run the unittest_compressor to see it fail. |
|
@liewegas She's at maternity leave at the moment, I'll take a look.. |
|
Thanks! In the meantime, this + the bluestore fix make the
ceph_test_objectstore test pass for me without those compression errors.
Although I promptly hit the stats error on fsck.
|
|
@ifed01 ok to merge this in the meantime? |
|
Will review in a couple hours... |
| @@ -0,0 +1,153 @@ | |||
| // -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*- | |||
There was a problem hiding this comment.
Test cases you removed were Intended for plugin load verification only. There is a couple more named test_compression_snappy (_zlib) that verify compression/decompression functionality. IMHO worth combining into a single file too.
|
yeah, i was about to do that but the zlib one has isa-related tests so i |
| g_conf->set_val("compressor_zlib_isal", "true"); | ||
| g_ceph_context->_conf->apply_changes(NULL); | ||
| } else if (isal == "noisal") { | ||
| g_conf->set_val("compressor_zlib_isal", "false"); |
There was a problem hiding this comment.
Undo to default on teardown?
liewegas
force-pushed
the
wip-compressor
branch
from
949de67
to
ec59f0a
Compare
|
updated
|
This obsoletes the per-plugin plugin tests, which are tedious anyway. Signed-off-by: Sage Weil <sage@redhat.com>
4 bytes is enough for small buffers, but fails for larger buffers because snappy encodes the length as a varint. 8 is enough. Signed-off-by: Sage Weil <sage@redhat.com>
We dynamically enable this if the necessary processor features are present. Allow this probing to be disabled explicitly. Signed-off-by: Sage Weil <sage@redhat.com>
This fails the unit tests. Do not reenable until it is fixed! Signed-off-by: Sage Weil <sage@redhat.com>
Just so it runs a bit faster! Signed-off-by: Sage Weil <sage@redhat.com>
This includes zlib and isal interop. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
| @@ -48,6 +49,13 @@ class CompressionTest : public ::testing::Test, | |||
| } | |||
| } | |||
| cout << "[plugin " << plugin << " (" << GetParam() << ")]" << std::endl; | |||
|
|
|||
| // note for later | |||
| old_zlib_isal = g_conf->compressor_zlib_isal; | |||
There was a problem hiding this comment.
Move upward prior to applying new values?
|
LGTM except old_zlib_isal setup. |
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-compressor
branch
from
00a2cb0
to
90de6e0
Compare
No description provided.