rocksdb: update to latest, and make it the default for the mons #11354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes my EnvMirror leak fix, which is now upstream. Signed-off-by: Sage Weil <sage@redhat.com>
We've been testing rocksdb on mons in QA for months now with no problems. We've also observed no problems with its use in bluestore. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
This assumes that if the mon does not explicitly specify the kv type that it is leveldb. No prior version of Ceph has had non-experimental rocksdb, so this is relatively safe. It's also necessary because the default is now 'rocksdb' and we shouldn't assume those old mons are rocksdb. This will break for users to explicitly specified rocksdb for the mon despite it being experimental. Signed-off-by: Sage Weil <sage@redhat.com>
|
this should go through jewel-x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.