mgr: misc minor changes #11386
Merged
mgr: misc minor changes #11386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiexingguo
force-pushed
the
xxg-wip-mgr-1008
branch
from
ea80ce6
to
6b01eef
Compare
|
@jcsp Can you take a look?(Just some cleanups, simple and easy) Thanks! |
|
retest this please |
xiexingguo
force-pushed
the
xxg-wip-mgr-1008
branch
from
6b01eef
to
20f6615
Compare
jcsp
approved these changes
Oct 17, 2016
| @@ -112,8 +112,7 @@ void MgrStandby::send_beacon() | |||
| available); | |||
|
|
|||
| monc->send_mon_message(m); | |||
| // TODO configure period | |||
| timer.add_event_after(5, new C_StdFunction( | |||
| timer.add_event_after(g_conf->mgr_beacon_period, new C_StdFunction( | |||
There was a problem hiding this comment.
Please could you add "Fixes: http://tracker.ceph.com/issues/17455" to the commit message
There was a problem hiding this comment.
@jcsp Done. Thanks for the review.
Fixes: http://tracker.ceph.com/issues/17455 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Which can fail due to missing keyring. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-mgr-1008
branch
from
20f6615
to
ce6b190
Compare
|
@jcsp Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.