os/bluestore: fix race condtion during blob spliting #11422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Oct 11, 2016
| @@ -1665,31 +1665,35 @@ void BlueStore::ExtentMap::reshard(Onode *o, uint64_t min_alloc_size) | |||
| // shard boundary. | |||
| bool must_span = false; | |||
| BlobRef b = ep->blob; | |||
| if (b->can_split()) { | |||
There was a problem hiding this comment.
I think a simpler fix would be to take the cache lock just for the can_split() writing.empty() check. We have the collection lock so no new writes will race with us.. only IO completion. So if writing is empty now it's safe the drop the lock and assume it will still be empty below when we do the split.
|
The other patches look good. Thanks! |
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Because it does not check anything, and removing it can speed up the process of fsck() Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xiexingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xiexingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1011
branch
2 times, most recently
from
4869ca0
to
5de22bd
Compare
As ep, sp and esp can be a little confusing. Signed-off-by: xiexingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1011
branch
from
5de22bd
to
d410573
Compare
|
@liewegas Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.