Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: build/ops: include more files in "make dist" tarball #11431

Merged
1 commit merged into from Oct 20, 2016

Conversation

ktdreyer
Copy link
Member

@ktdreyer ktdreyer commented Oct 11, 2016

http://tracker.ceph.com/issues/17560

Include all the documentation, qa, and CMakeLists.txt files in the make dist tarball.

Kraken and newer releases will already do this. This change is restricted to releases that still use autotools (jewel in this case).

The purpose of this change is to make it easier to apply downstream patches on an unpacked upstream tarball, because often those patches are cherry-picks of commits that touch files under doc/, qa/, or CMakeLists.txt.

@ktdreyer ktdreyer added this to the jewel milestone Oct 11, 2016
@ktdreyer ktdreyer changed the title build: include more files in "make dist" tarball jewel: build: include more files in "make dist" tarball Oct 11, 2016
Include all the documentation, qa, and CMakeLists.txt files in the "make
dist" tarball.

Kraken and newer releases will already do this. This change is
restricted to releases that still use autotools.

The purpose of this change is to make it easier to apply downstream
patches on an unpacked upstream tarball, because often those patches are
cherry-picks of commits that touch files under doc/, qa/, or
CMakeLists.txt.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
@ghost ghost changed the title jewel: build: include more files in "make dist" tarball jewel: build/ops: include more files in "make dist" tarball Oct 11, 2016
@ghost
Copy link

ghost commented Oct 11, 2016

I'll create the matching Backport issue in the tracker as soon as it comes back online.

@b-ranto
Copy link
Contributor

b-ranto commented Oct 11, 2016

lgtm

@smithfarm
Copy link
Contributor

No objections.

ghost pushed a commit that referenced this pull request Oct 13, 2016
…ake dist" tarball

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 17, 2016
…ake dist" tarball

Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost pushed a commit that referenced this pull request Oct 18, 2016
…ake dist" tarball

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost
Copy link

ghost commented Oct 20, 2016

It passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17487#note-22) suites.

@ghost ghost merged commit 410a368 into jewel Oct 20, 2016
@liewegas liewegas deleted the wip-jewel-tarball branch November 23, 2016 20:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants