rbd-nbd: support disabling auto-exclusive lock transition logic #11438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Oct 12, 2016
| @@ -64,13 +64,15 @@ static void usage() | |||
| << " --device <device path> Specify nbd device path\n" | |||
| << " --read-only Map readonly\n" | |||
| << " --nbds_max <limit> Override for module param\n" | |||
| << " --single-client Forbid other clients write\n" | |||
There was a problem hiding this comment.
Minor: how about just "--exclusive" or "--exclusive-client"?
|
... also need to update the rbd CLI help.t cram test case |
Fixes: http://tracker.ceph.com/issues/17488 Signed-off-by: Mykola Golub <mgolub@mirantis.com>
|
@dillaman Thanks, updated. |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17488
Signed-off-by: Mykola Golub mgolub@mirantis.com