Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds/DamageTable: move classes to .cc file #11450

Merged
merged 1 commit into from Oct 19, 2016

Conversation

stiopaa1
Copy link
Contributor

Signed-off-by: Michal Jarzabek stiopa@gmail.com

Signed-off-by: Michal Jarzabek <stiopa@gmail.com>
@liewegas liewegas added cephfs Ceph File System cleanup labels Oct 13, 2016
@gregsfortytwo
Copy link
Member

Sure, looks good. I see this also adds the anonymous namespacing.

@stiopaa1
Copy link
Contributor Author

@gregsfortytwo
Even if we don't want don't want to modify existing code to introduce anonymous namespaces I guess there is no harm adding them if I'm changing to code in this area anyway?
Some time ago with very similar commit I was even asked by @tchaikov to add anonymous namespace.

@jcsp jcsp merged commit f958943 into ceph:master Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants