os/bluestore: traverse buffer_map in reverse order when spliting BufferSpace #11468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Which is depreciated by ceph@7260166#diff-6519c151b74b5a9355a697be278a4382 Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1013
branch
from
f536621
to
d476053
Compare
Which is more efficient. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
xiexingguo
force-pushed
the
xxg-wip-bluestore-1013
branch
from
d476053
to
4262859
Compare
|
Why is going in reverse more efficient? |
xiexingguo
commented
Oct 13, 2016
| p->second->end() <= pos) { | ||
| dout(30) << __func__ << " skip " << *p->second << dendl; | ||
| ++p; | ||
| } |
There was a problem hiding this comment.
@liewegas
So we can avoid the skip process above, especially if we have to skip all.
|
Ah, of course
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.