build/ops: deb: add python dependencies where needed #11507
Conversation
|
jenkins test this please |
|
Pretty sure the make check failure is unrelated to this PR. A quick glance shows at least one other PR suffering from the same failure: #11509 |
| Depends: ceph-base (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends} | ||
| Depends: ceph-base (= ${binary:Version}), | ||
| ${misc:Depends}, | ||
| ${python:Depends}, |
There was a problem hiding this comment.
why ceph-mds depends on ${python:Depends}?
| Depends: ceph-base (= ${binary:Version}), ${misc:Depends}, ${shlibs:Depends} | ||
| Depends: ceph-base (= ${binary:Version}), | ||
| ${misc:Depends}, | ||
| ${python:Depends}, |
There was a problem hiding this comment.
we don't run ceph-mgr through dh_python2 or dh_python3 in debian/rules yet. but since we install src/pybind/mgr, probably we should update override_dh_python3 and override_dh_python2 accordingly?
| @@ -600,6 +609,7 @@ Depends: ceph-common (= ${binary:Version}), | |||
| mime-support, | |||
| librgw2 (= ${binary:Version}), | |||
| ${misc:Depends}, | |||
| ${python:Depends}, | |||
There was a problem hiding this comment.
i don't think radosgw depends on python. could you elaborate a little bit?
|
@tchaikov Thanks for reviewing! I added a commit - does it come closer to what you are suggesting? |
smithfarm
changed the title
| @@ -172,6 +177,7 @@ Architecture: linux-any | |||
| Depends: ceph-base (= ${binary:Version}), | |||
| python-flask, | |||
| ${misc:Depends}, | |||
| ${python:Depends}, | |||
There was a problem hiding this comment.
@smithfarm i don't think the monitor depends on python in any way. could you remove this line?
There was a problem hiding this comment.
That's the whole purpose of this PR, actually. Please have a look at the tracker issue. I don't know exactly what's going on, but when only the "ceph-mon" package is installed, it is impossible to run "/usr/bin/ceph". For example:
$ ceph --version
Traceback (most recent call last):
File "/usr/bin/ceph", line 101, in <module>
import rados
ImportError: libpython2.7.so.1.0: cannot open shared object file: No such file or directory
Now, libpython2.7.so.1.0 is presumably in the libpython2.7 package, but that package is not getting installed when someone does "apt-get install ceph-mon". It does get installed when someone does "apt-get install ceph-osd" and ceph-osd does depend on ${python:Depends}.
There was a problem hiding this comment.
see the notes at http://tracker.ceph.com/issues/17579#note-7
| @@ -150,6 +150,8 @@ override_dh_python2: | |||
| dh_python2 -p ceph-common | |||
| dh_python2 -p ceph-base | |||
| dh_python2 -p ceph-osd | |||
| dh_python2 -p ceph-mon | |||
| dh_python2 -p ceph-mgr | |||
|
|
|||
| override_dh_python3: | |||
| for binding in rados cephfs rbd; do \ | |||
There was a problem hiding this comment.
@smithfarm could you add dh_python3 -p ceph-mgr to override_dh_python3 accordingly? and maybe we don't need to run ceph-mon through dh_python2?
There was a problem hiding this comment.
Added another commit. I don't have any Debian system to test this on, unfortunately.
|
@tchaikov It would be interesting to test if libpython2.7 gets installed when someone does "apt-get install ceph-common" (since /usr/bin/ceph is in the ceph-common package, that's where libpython2.7 should be getting pulled in as a dependency, but apparently isn't). |
|
@smithfarm i updated your commits with the changes in my mind, squashed the related ones, and pushed to https://github.com/tchaikov/ceph/tree/wip-11507, does it make sense to you? |
|
@tchaikov The commit is missing |
|
@smithfarm i updated https://github.com/tchaikov/ceph/commits/wip-11507 to address your comment, and pushed to the branch you are using =) |
tchaikov
changed the title
|
Now the unrelated failing test is |
|
I was able to install ceph-mon with this branch and not get into issues. This needs to be rebased though, I am not seeing other fixes that were recently merged that prevent this: |
Signed-off-by: Nathan Cutler <ncutler@suse.com>
this reverts 48f4576 and f140a8c Fixes: http://tracker.ceph.com/issues/17579 Signed-off-by: Nathan Cutler <ncutler@suse.com> Signed-off-by: Kefu Chai <kchai@redhat.com>
|
Rebased. |
http://tracker.ceph.com/issues/17579