jewel: utime.h: fix timezone issue in round_to_* funcs. #11508
Conversation
…d_to_* funcs. Reviewed-by: Loic Dachary <ldachary@redhat.com>
…d_to_* funcs. Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
assigned 
|
@athanatos does this backport look good to merge ? It passed the rados (http://tracker.ceph.com/issues/17487#note-19) suite except for two jobs that are, I believe unrelated. It also passed the upgrade/jewel-x and upgrade/hammer-x (http://tracker.ceph.com/issues/17487#note-22) suites. |
|
Hmm, looks like I merged the original patch, but @yehudasa should take a look at this since rgw is the only user of these functions. It's used in rgw_log, so I'm not sure what the impact of changing the time in jewel would be. |
ghost
changed the base branch from
|
@smithfarm could you please rebase against jewel-next so that we get another run of make check ? |
|
@yehudasa ping |
gmtime_r converts local time to UTC, however mktime only takes an argument as local time. Use localtime_r instead of gmtime_r will fix. Fixes: ceph#14862 Reported-by: isyippee <yippee_liu@163.com> Signed-off-by: Zhao Chao <zhaochao1984@gmail.com> (cherry picked from commit c914f28)
smithfarm
force-pushed
the
wip-17583-jewel
branch
from
aaa6087
to
4f8287f
Compare
|
jenkins test this please (jenkins general failure) |
|
jenkins test this please (general jenkins failure) |
…d_to_* funcs. Reviewed-by: Loic Dachary <ldachary@redhat.com>
…d_to_* funcs. Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa ping |
…d_to_* funcs. Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@yehudasa @oritwas Could you review this, please? Sam says rgw is the only user of these functions. See #11508 (comment) |
|
This passed another rados run at http://tracker.ceph.com/issues/17851#note-45 (with some unrelated failures) |
http://tracker.ceph.com/issues/17583