Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/encoding/readable.sh: fix shell script warning #11527

Merged
merged 1 commit into from Nov 4, 2016

Conversation

wjwithagen
Copy link
Contributor

shell complains about:
continue: only meaningful in afor', while', oruntil' loop`

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@liewegas
Copy link
Member

In that case the loop needs to be restructured?

@liewegas liewegas added the tests label Oct 18, 2016
@wjwithagen
Copy link
Contributor Author

@liewegas
I have the feeling that it is just a "left-over" from cut&paste.
But I'll try and see if I can figure it out.

@wjwithagen
Copy link
Contributor Author

@liewegas
It is weird indeed. Perhaps this would explain possible errors on my jenkins VM as well.
My dev box seems to work without much trouble.

@wjwithagen
Copy link
Contributor Author

@liewegas
Nope, code does need to be restructured, since there is no outside loop to reference , and this test really does want to skip. At least that is what the comment and code is hinting.
Will make a new patch

@@ -69,7 +69,6 @@ test_object() {
if [ -n "$incompat" ]; then
if [ -z "$incompat_paths" ]; then
echo "skipping incompat $type version $arversion, changed at $incompat < code $myversion"
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be return, i guess.

@wjwithagen
Copy link
Contributor Author

@liewegas @tchaikov
Yup, I replaced the continue with return before I went to my meeting and that helps.
No more complaints about language, and my FreeBSD tests do not abort.
I'll commit a fix.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@tchaikov
Copy link
Contributor

tchaikov commented Nov 2, 2016

lgtm.

@liewegas liewegas added this to the kraken milestone Nov 3, 2016
@liewegas liewegas merged commit d95d522 into ceph:master Nov 4, 2016
@wjwithagen wjwithagen deleted the wip-wjw-readable.sh branch January 4, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants