mds: use unique_ptr to simplify resource mgmt #11543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -183,7 +183,6 @@ CDir::CDir(CInode *in, frag_t fg, MDCache *mdcache, bool auth) : | |||
| first(2), | |||
| dirty_rstat_inodes(member_offset(CInode, dirty_rstat_item)), | |||
| projected_version(0), item_dirty(this), item_new(this), | |||
| scrub_infop(NULL), | |||
| num_head_items(0), num_head_null(0), | |||
| num_snap_items(0), num_snap_null(0), | |||
| num_dirty(0), committing_version(0), committed_version(0), | |||
There was a problem hiding this comment.
bloom(null) is redundant
|
👍 |
batrick
force-pushed
the
cdir-unique-ptr
branch
3 times, most recently
from
0eb7e79
to
6dfd0e1
Compare
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
batrick
force-pushed
the
cdir-unique-ptr
branch
from
6dfd0e1
to
125ac74
Compare
|
@jcsp, I've made a few corrections due to build errors. I think this is ready for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FYI, this was originally part of a large branch I've been sitting on for a few months. Unfortunately that branch grew too large making it difficult to go through compile errors. So, I'm breaking it up over time into smaller PRs.]