librbd: cannot access non-primary image when mirroring force disabled #11568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest this please |
trociny
pushed a commit
that referenced
this pull request
Oct 29, 2016
librbd: cannot access non-primary image when mirroring force disabled #11568
trociny
reviewed
Oct 30, 2016
| })} | ||
| }, 0); | ||
| expect_journal_client_unregister(mock_image_ctx, "peer 1", -EINVAL); | ||
| expect_snap_remove(mock_image_ctx, "snap 1", 0); |
There was a problem hiding this comment.
@dillaman Observing this test (also SnapRemoveError, and I suppose some other) fails sporadically (--gtest_repeat=100) due to a race between unregister_client from "peer 1" and snap_remove from "peer 2", as they run concurrently and snap_remove may finish earlier than client_unregister:
2016-10-30 12:46:15.266679 7ff8d07b1980 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_get_mirror_image
2016-10-30 12:46:15.266709 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 handle_get_mirror_image: r=0
2016-10-30 12:46:15.266712 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_get_tag_owner
2016-10-30 12:46:15.266736 7ff8b6ffd700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 handle_get_tag_owner: r=0
2016-10-30 12:46:15.266738 7ff8b6ffd700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_set_mirror_image
2016-10-30 12:46:15.266763 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 handle_set_mirror_image: r=0
2016-10-30 12:46:15.266764 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_notify_mirroring_watcher
2016-10-30 12:46:15.266771 7ff8b6ffd700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 handle_notify_mirroring_watcher: r=0
2016-10-30 12:46:15.266773 7ff8b6ffd700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_get_clients
2016-10-30 12:46:15.266813 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 handle_get_clients: r=0
2016-10-30 12:46:15.266817 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_unregister_client
2016-10-30 12:46:15.266826 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_remove_snap: client_id=peer 2, snap_name=snap 1
2016-10-30 12:46:15.266832 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 send_remove_snap: client_id=peer 2, snap_name=snap 2
2016-10-30 12:46:15.266870 7ff8bd92d700 10 librbd::mirror::DisableRequest: 0x7ff8d926eef0 handle_unregister_client: r=-22
2016-10-30 12:46:15.266873 7ff8bd92d700 -1 librbd::mirror::DisableRequest: failed to unregister remote journal client: (22) Invalid argument
added 7 commits
October 31, 2016 10:57
Fixes: http://tracker.ceph.com/issues/16740 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
If mirroring is force disabled on a demoted image, the journal was being left in an inconsistent ownership state. Fixes: http://tracker.ceph.com/issues/17588 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
This facilitates being able to properly mock test cases around journal cls method calls. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@trociny update pushed |
trociny
pushed a commit
that referenced
this pull request
Oct 31, 2016
librbd: cannot access non-primary image when mirroring force disabled #11568
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.