jewel: rgw multisite: obsolete 'radosgw-admin period prepare' command #11574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All that the 'radosgw-admin period prepare' command does is create an empty period and write it to rados. When we added the staging period (see 'period get --staging'), uncommitted changes were written to that instead - so the 'period prepare' command became obsolete. It should be removed! Fixes: http://tracker.ceph.com/issues/17387 Reported-by: Casey Bodley <cbodley@redhat.com> Signed-off-by: Gaurav Kumar Garg <garg.gaurav52@gmail.com> (cherry picked from commit 1508c70)
|
jenkins test this please (rbd failure) |
|
@dachary it seems from jenkins "All checks have passed" |
ghost
changed the base branch from
|
jenkins test this please |
|
jenkins test this please (jenkins general failure) |
|
jenkins test this please (general jenkins failure) |
ghost
changed the title
ghost
pushed a commit
that referenced
this pull request
Nov 9, 2016
…min period prepare' command Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@cbodley does this backport look good to merge ? It passed the rgw suite http://tracker.ceph.com/issues/17851#note-3 . Note that it will not be in 10.2.4, reason why it targets jewel-next. |
|
👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/17507