rgw: fix for passing temporary in InitBucketSyncStatus #11594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/17661 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
@cbodley lgtm.. did it go through testing? |
|
@yehudasa just validated with manual testing - we don't have any automated tests that cover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RGWInitBucketShardSyncStatusCoroutine was recently changed to store its sync_status by reference. This works fine when called via RGWRunBucketShardSyncCoroutine, but not in RGWBucketSyncStatusManager::init_sync_status() which is used by radosgw-admin. RGWBucketSyncStatusManager::init_sync_status() returns a coroutine with a reference to a temporary local variable, leading to a crash
Fixes: http://tracker.ceph.com/issues/17661