ceph-disk: missing return when a file is used for journal

[jayaajay]

http://tracker.ceph.com/issues/17662

ceps-disk is missing a return statement when preparing the journal space when it is regular file.

[cbodley]

thank you! could you please add Fixes: http://tracker.ceph.com/issues/17662 to your commit message? we also need a Signed-off-by: line (you can git commit --amend -s)

[ghost]

good catch !

[ghost]

I'll add a test for that so it stays fixed.

[ghost]

@jayaajay I amended your commit to add tests and fix another issue, could you please review it ? #11619

[jayaajay]

Done!

On Oct 21, 2016, at 2:06 PM, Casey Bodley <notifications@github.commailto:notifications@github.com> wrote:

thank you! could you please add Fixes: http://tracker.ceph.com/issues/17662 to your commit message? we also need a Signed-off-by: line (you can git commit --amend -s)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/11600#issuecomment-255435182, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKMUaYJ37qtLQpRfZWUQ2iQBCfSOCw3Iks5q2P81gaJpZM4KddBg.