librbd: ensure consistency groups will gracefully fail on older OSDs #11623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempting to retrieve the group spec will fail on older OSDs, so it must be executed as an individual step in the refresh state machine. Also fixed code style issues for out parameters. Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
retest this please |
trociny
pushed a commit
that referenced
this pull request
Oct 29, 2016
librbd: ensure consistency groups will gracefully fail on older OSDs #11623
|
lgtm |
trociny
pushed a commit
that referenced
this pull request
Oct 31, 2016
librbd: ensure consistency groups will gracefully fail on older OSDs #11623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to retrieve the group spec will fail on older OSDs, so it
must be executed as an individual step in the refresh state machine.
Also fixed code style issues for out parameters.
Signed-off-by: Jason Dillaman dillaman@redhat.com